Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos mostly in comments, docs and test names #15209

Merged
merged 6 commits into from
Aug 30, 2019
Merged

Fix typos mostly in comments, docs and test names #15209

merged 6 commits into from
Aug 30, 2019

Conversation

minho42
Copy link
Contributor

@minho42 minho42 commented Aug 11, 2019

Found some more typos in various files.

epicfaace
epicfaace suggested changes Aug 27, 2019
View reviewed changes
Doc/library/importlib.rst Outdated Show resolved Hide resolved
Lib/test/test_winreg.py Outdated Show resolved Hide resolved
Lib/unittest/test/testmock/testpatch.py Outdated Show resolved Hide resolved
minho42 and others added 2 commits August 31, 2019 01:43
@minho42 @epicfaace
inexistent -> nonexistent
636dfd7 
Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
@minho42 @epicfaace
progagrates -> progagates
88c0489 
Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
@terryjreedy
Copy link
Member

I am going to make and backport the idlelib changes, revert here, and then review.

minho42 and others added 3 commits August 31, 2019 05:25
@minho42 @epicfaace
being -> is
125cb19 
Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
@terryjreedy
Revert idlelib/README.txt
ffe562d 
Fix in separate PR
@terryjreedy
ditto for idlelib.browser
df2862f
@terryjreedy terryjreedy mentioned this pull request Aug 30, 2019
Merged
terryjreedy
terryjreedy approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look correct and non-controversial. I checked that the only code change (LOADLIBARYEX to LOADLIBRARYEX) was complete and consistent.

Modules/expat/loadlibrary.c Show resolved Hide resolved
@terryjreedy terryjreedy merged commit 39d87b5 into python:master Aug 30, 2019
@miss-islington
Copy link
Contributor

Thanks @minho42 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 30, 2019
@minho42 @miss-islington
Fix typos mostly in comments, docs and test names (pythonGH-15209)
219506e 
(cherry picked from commit 39d87b5)

Co-authored-by: Min ho Kim <minho42@gmail.com>
@bedevere-bot
Copy link

GH-15620 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Thanks @minho42 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @minho42 and @terryjreedy, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 39d87b54715197ca9dcb6902bb43461c0ed701a2 3.7

@terryjreedy
Copy link
Member

I expected the 3.8 backport to fail; good thing I tried it anyway.
If you or anyone makes a 3.7 backport PR, I think the LOADLIBARYEX fix should be skipped in case people have used it in their code. They should not be surprised until they try 3.8.

miss-islington added a commit that referenced this pull request Aug 30, 2019
@miss-islington @minho42
Fix typos mostly in comments, docs and test names (GH-15209)
4bd1d05 
(cherry picked from commit 39d87b5)

Co-authored-by: Min ho Kim <minho42@gmail.com>
@minho42
Copy link
Contributor Author

minho42 commented Aug 31, 2019

Thank you @terryjreedy

@minho42 minho42 deleted the Fixed-typos branch August 31, 2019 02:50
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@minho42 @lisroach
Fix typos mostly in comments, docs and test names (pythonGH-15209)
75869bb
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@minho42 @DinoV
Fix typos mostly in comments, docs and test names (pythonGH-15209)
eb68959
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@minho42 @websurfer5
Fix typos mostly in comments, docs and test names (pythonGH-15209)
c8b6412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace requested changes

@terryjreedy terryjreedy terryjreedy approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@rhettinger rhettinger Awaiting requested review from rhettinger

@tiran tiran Awaiting requested review from tiran

Assignees

@terryjreedy terryjreedy

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@minho42 @terryjreedy @miss-islington @bedevere-bot @epicfaace @the-knights-who-say-ni