-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() #15266
Conversation
8f96826
to
fa18af8
Compare
5a77376
to
ba81a90
Compare
The usual way we do this is to define the function in pure python. Then, somewhere below that definition, try to import the C accelerator function in its place. For examples, see line 458 in Lib/collections/__init__.py for _count_elements() or line 579 in Lib/heapq.py |
Thanks a lot. |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @rhettinger: please review the changes made to this pull request. |
@rhettinger Can you please take a look? |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks for doing this. I think we're getting close :-) |
Thanks for the review, I will take look at! |
@rhettinger I've updated the PR! |
Thanks @corona10 for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
GH-15441 is a backport of this pull request to the 3.8 branch. |
Nice work. Thanks for doing this :-) |
https://bugs.python.org/issue37798