Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to time function from time_ns doc #15285

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Conversation

merwok
Copy link
Member

@merwok merwok commented Aug 14, 2019

Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.

Automerge-Triggered-By: @merwok

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I didn't know about the ~time.time syntax.

@merwok
Copy link
Member Author

merwok commented Aug 17, 2019

I don’t have a link handy, but for any interested reader: tilde is a way to refer to something with a full path (module.object or module.class.method), but only render the last bit as link text.

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 1b1d051 into master Aug 17, 2019
@miss-islington miss-islington deleted the fix-time_ns-link branch August 17, 2019 20:34
@miss-islington
Copy link
Contributor

Thanks @merwok for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2019
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
(cherry picked from commit 1b1d051)

Co-authored-by: Éric Araujo <merwok@netwok.org>
@bedevere-bot
Copy link

GH-15321 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15322 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2019
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
(cherry picked from commit 1b1d051)

Co-authored-by: Éric Araujo <merwok@netwok.org>
miss-islington added a commit that referenced this pull request Aug 17, 2019
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
(cherry picked from commit 1b1d051)

Co-authored-by: Éric Araujo <merwok@netwok.org>
miss-islington added a commit that referenced this pull request Aug 17, 2019
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
(cherry picked from commit 1b1d051)


Co-authored-by: Éric Araujo <merwok@netwok.org>

Automerge-Triggered-By: @merwok
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Because mod, func, class, etc all share one namespace, :func:time creates a link to the time module doc page rather than the time.time function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants