Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37703: improve asyncio.gather documentation regarding cancellation #15312

Merged
merged 1 commit into from
Jul 20, 2020
Merged

bpo-37703: improve asyncio.gather documentation regarding cancellation #15312

merged 1 commit into from
Jul 20, 2020

Conversation

vinay0410
Copy link
Contributor

@vinay0410 vinay0410 commented Aug 16, 2019 •
edited by miss-islington
Loading

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

https://bugs.python.org/issue37703

Automerge-Triggered-By: @asvetlov

@vinay0410 vinay0410 force-pushed the fix-issue-37703 branch 3 times, most recently from 1498a45 to 12bf07d Compare August 16, 2019 14:58
asvetlov
asvetlov approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1st1 Yuri, please review

1st1
1st1 previously requested changes Aug 26, 2019
View reviewed changes
Doc/library/asyncio-task.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vinay0410
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@1st1, @asvetlov: please review the changes made to this pull request.

@vinay0410
Copy link
Contributor Author

@1st1 , Could you please review this ?

1st1
1st1 reviewed Oct 4, 2019
View reviewed changes
Doc/library/asyncio-task.rst Outdated Show resolved Hide resolved
@vinay0410
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@1st1, @asvetlov: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested review from 1st1 and asvetlov July 19, 2020 14:33
@asvetlov asvetlov added the needs backport to 3.9 only security fixes label Jul 19, 2020
@asvetlov asvetlov dismissed 1st1’s stale review July 20, 2020 08:22

Notes are fixed I think

@asvetlov asvetlov closed this Jul 20, 2020
@asvetlov asvetlov reopened this Jul 20, 2020
@asvetlov
Copy link
Contributor

Reopened to ping the TravisCI

@miss-islington
Copy link
Contributor

@vinay0410: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d42528a into python:master Jul 20, 2020
@miss-islington
Copy link
Contributor

Thanks @vinay0410 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2020
@vinay0410 @miss-islington
bpo-37703: improve asyncio.gather documentation regarding cancellation (
6bd4da6 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
(cherry picked from commit d42528a)

Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>
@bedevere-bot
Copy link

GH-21557 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 20, 2020
@bedevere-bot
Copy link

GH-21558 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-21559 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2020
@vinay0410 @miss-islington
bpo-37703: improve asyncio.gather documentation regarding cancellation (
ea2db76 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
(cherry picked from commit d42528a)

Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2020
@vinay0410 @miss-islington
bpo-37703: improve asyncio.gather documentation regarding cancellation (
f05f387 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
(cherry picked from commit d42528a)

Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>
miss-islington added a commit that referenced this pull request Jul 20, 2020
@miss-islington @vinay0410
bpo-37703: improve asyncio.gather documentation regarding cancellation (
58f59a9 
GH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
(cherry picked from commit d42528a)

Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>
miss-islington added a commit that referenced this pull request Jul 20, 2020
@miss-islington @vinay0410
bpo-37703: improve asyncio.gather documentation regarding cancellation (
46634b7 
GH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
(cherry picked from commit d42528a)

Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@vinay0410 @arun-mani-j
bpo-37703: improve asyncio.gather documentation regarding cancellation (
cc37a46 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@vinay0410 @shihai1991
bpo-37703: improve asyncio.gather documentation regarding cancellation (
a2425a2 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@vinay0410 @shihai1991
bpo-37703: improve asyncio.gather documentation regarding cancellation (
d43a3a8 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@vinay0410
bpo-37703: improve asyncio.gather documentation regarding cancellation (
a3bbe3b 
pythonGH-15312)

These changes updates the doc to comprehensively mention the behaviour of gather.cancel()

Automerge-Triggered-By: @asvetlov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinay0410 @bedevere-bot @asvetlov @miss-islington @1st1 @the-knights-who-say-ni