Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an invalid assertEqual() call in test_descr.py #15318

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Fix an invalid assertEqual() call in test_descr.py #15318

merged 1 commit into from
Aug 26, 2019

Conversation

ZackerySpytz
Copy link
Contributor

It seems that self.fail() was intended, not self.assertEqual().

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 17, 2019
@ZackerySpytz ZackerySpytz changed the title Fix an invalid assertRaises() call in test_descr.py Fix an invalid assertEqual() call in test_descr.py Aug 17, 2019
tirkarthi
tirkarthi approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commit 479a7e7 changes raise TestFailed(reason) statements to use self.fail and the check is done correctly test_classmethods. Thanks.

@pablogsal pablogsal merged commit 6b2e325 into python:master Aug 26, 2019
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15533 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2019
@ZackerySpytz @miss-islington
Fix an invalid assertEqual() call in test_descr.py (pythonGH-15318)
804a956 
(cherry picked from commit 6b2e325)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2019
@ZackerySpytz @miss-islington
Fix an invalid assertEqual() call in test_descr.py (pythonGH-15318)
af44a74 
(cherry picked from commit 6b2e325)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-15534 is a backport of this pull request to the 3.7 branch.

@pablogsal
Copy link
Member

Thanks, @ZackerySpytz for the PR!

miss-islington added a commit that referenced this pull request Aug 26, 2019
@miss-islington @ZackerySpytz
Fix an invalid assertEqual() call in test_descr.py (GH-15318)
31ce015 
(cherry picked from commit 6b2e325)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Aug 26, 2019
@miss-islington @ZackerySpytz
Fix an invalid assertEqual() call in test_descr.py (GH-15318)
c75f0e5 
(cherry picked from commit 6b2e325)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@ZackerySpytz @lisroach
Fix an invalid assertEqual() call in test_descr.py (pythonGH-15318)
d0af417
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ZackerySpytz @DinoV
Fix an invalid assertEqual() call in test_descr.py (pythonGH-15318)
2ef2f29
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@ZackerySpytz @websurfer5
Fix an invalid assertEqual() call in test_descr.py (pythonGH-15318)
dbdb497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @miss-islington @bedevere-bot @pablogsal @tirkarthi @the-knights-who-say-ni