Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37902: IDLE: Add scrolling for IDLE browsers. #15368

Merged
merged 14 commits into from
Sep 5, 2019
Merged

bpo-37902: IDLE: Add scrolling for IDLE browsers. #15368

merged 14 commits into from
Sep 5, 2019

Conversation

GeeTransit
Copy link
Contributor

@GeeTransit GeeTransit commented Aug 21, 2019 •
edited by bedevere-bot
Loading

terryjreedy
terryjreedy requested changes Aug 21, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen previous comment re spaces and issue comment about how to not duplicate mousescroll.

Misc/NEWS.d/next/IDLE/2019-08-21-16-02-49.bpo-37902._R_adE.rst Outdated Show resolved Hide resolved
Lib/idlelib/NEWS.txt Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@GeeTransit
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@terryjreedy
Copy link
Member

I fix the bug with editor windows wherein wheel_event was be called with (editor, event) instead of (event,), due to the 'self.' in the binding, by moving import and removing 'self.'. I manually checked 3 types of editor and browser windows -- all good.

Passing expected args to the mock widget and testing in the mock method is an interesting idea. I am used to extracting called args and testing in the test method. Test looks good. I will post 2 possible refinements to the issue but am merging this now.

@terryjreedy terryjreedy added needs backport to 3.8 type-feature A feature request or enhancement labels Sep 5, 2019
@terryjreedy terryjreedy merged commit 2cd9025 into python:master Sep 5, 2019
@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @GeeTransit for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Sorry @GeeTransit and @terryjreedy, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2cd902585815582eb059e3b40e014ebe4e7fdee7 3.7

@miss-islington
Copy link
Contributor

Thanks @GeeTransit for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @GeeTransit for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15689 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15690 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2019
@GeeTransit @miss-islington
bpo-37902: IDLE: Add scrolling for IDLE browsers. (pythonGH-15368)
703e947 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
(cherry picked from commit 2cd9025)

Co-authored-by: GeeTransit <geetransit@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2019
@GeeTransit @miss-islington
bpo-37902: IDLE: Add scrolling for IDLE browsers. (pythonGH-15368)
6ec445d 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
(cherry picked from commit 2cd9025)

Co-authored-by: GeeTransit <geetransit@gmail.com>
miss-islington added a commit that referenced this pull request Sep 5, 2019
@miss-islington @GeeTransit
bpo-37902: IDLE: Add scrolling for IDLE browsers. (GH-15368)
9c2654d 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
(cherry picked from commit 2cd9025)

Co-authored-by: GeeTransit <geetransit@gmail.com>
miss-islington added a commit that referenced this pull request Sep 5, 2019
@miss-islington @GeeTransit
bpo-37902: IDLE: Add scrolling for IDLE browsers. (GH-15368)
16af39a 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
(cherry picked from commit 2cd9025)

Co-authored-by: GeeTransit <geetransit@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@GeeTransit @lisroach
bpo-37902: IDLE: Add scrolling for IDLE browsers. (python#15368)
fca8fed 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@GeeTransit @DinoV
bpo-37902: IDLE: Add scrolling for IDLE browsers. (python#15368)
8310012 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@GeeTransit @websurfer5
bpo-37902: IDLE: Add scrolling for IDLE browsers. (python#15368)
d53589d 
Modify the wheel event handler so it can also be used for module, path, and stack browsers.
Patch by George Zhang.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GeeTransit @bedevere-bot @terryjreedy @miss-islington @the-knights-who-say-ni