-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-37902: IDLE: Add scrolling for IDLE browsers. #15368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen previous comment re spaces and issue comment about how to not duplicate mousescroll.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-Authored-By: Terry Jan Reedy <tjreedy@udel.edu>
I have made the requested changes; please review again |
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
# Conflicts resolved: # Lib/idlelib/editor.py
I fix the bug with editor windows wherein wheel_event was be called with (editor, event) instead of (event,), due to the 'self.' in the binding, by moving import and removing 'self.'. I manually checked 3 types of editor and browser windows -- all good. Passing expected args to the mock widget and testing in the mock method is an interesting idea. I am used to extracting called args and testing in the test method. Test looks good. I will post 2 possible refinements to the issue but am merging this now. |
@terryjreedy: Please replace |
Thanks @GeeTransit for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
I'm having trouble backporting to |
Sorry @GeeTransit and @terryjreedy, I had trouble checking out the |
Thanks @GeeTransit for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Thanks @GeeTransit for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-15689 is a backport of this pull request to the 3.8 branch. |
GH-15690 is a backport of this pull request to the 3.7 branch. |
Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang. (cherry picked from commit 2cd9025) Co-authored-by: GeeTransit <geetransit@gmail.com>
Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang. (cherry picked from commit 2cd9025) Co-authored-by: GeeTransit <geetransit@gmail.com>
Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang.
Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang.
Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang.
https://bugs.python.org/issue37902