bpo-12634: Clarify an awkward section of the tutorial #15406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
added
docs
eamanu
approved these changes
Aug 23, 2019
terryjreedy
reviewed
Aug 23, 2019
| it is wise to use some kind of convention that minimizes the chance of | ||
| conflicts. Possible conventions include capitalizing method names, prefixing | ||
| data attribute names with a small unique string (perhaps just an underscore), or | ||
| using verbs for methods and nouns for data attributes. |
There was a problem hiding this comment.
Wow. At first I was confused. If one defines module, class, or instance attributes with the same name, the second wins. Then the first two advice items are wrong, the third correct, but misses the realistic case of noun data attribute duplication on class and instance. Your example covers that nicely. Please apply and backport.
terryjreedy
approved these changes
Aug 23, 2019
terryjreedy
requested changes
Aug 23, 2019
|
When you're done making the requested changes, leave the comment: |
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-15409 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2019
(cherry picked from commit 483ae0c) Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger
added a commit
that referenced
this pull request
Aug 23, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue12634