bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs #15522

corona10 · 2019-08-26T16:04:36Z

https://bugs.python.org/issue22347

Automerge-Triggered-By: @maxking

corona10 · 2019-08-26T16:24:58Z

@zooba @asvetlov
This issue is pretty old remained an issue. I'd like to close this issue.
Can you please take a look?

Misc/NEWS.d/next/Library/2019-08-27-01-03-26.bpo-22347._TRpYr.rst

Lib/mimetypes.py

Lib/test/test_mimetypes.py

corona10 · 2019-08-27T02:17:42Z

@epicfaace
Thanks for the review. I 've updated the PR. Please take a look

epicfaace

Looks good!

corona10 · 2019-08-27T04:47:48Z

Thanks alot!

Lib/mimetypes.py

maxking

Thanks @corona10 , The changes look good to me, except for the import statements (which I don't think needs any changes).

Please make sure to not force-pus after the changes and just add another additional commit. Merging the PR will squash the commits.

It is easier to lookup what changes were made after reviews through the additional commits and it gets lost if you force-push.

bedevere-bot · 2019-08-31T17:52:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10 · 2019-08-31T20:51:44Z

@maxking
Thanks for the review, I will keep in mind not to use push force. :)
I've reverted the import.

corona10 · 2019-09-03T09:57:39Z

I have made the requested changes; please review again

bedevere-bot · 2019-09-03T09:57:42Z

Thanks for making the requested changes!

@maxking: please review the changes made to this pull request.

maxking

I think it looks good.

Thanks @corona10 !

miss-islington · 2019-09-05T00:34:38Z

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

pythonGH-15522) https://bugs.python.org/issue22347 (cherry picked from commit 87bd207) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot · 2019-09-05T00:34:49Z

GH-15685 is a backport of this pull request to the 3.8 branch.

miss-islington · 2019-09-05T00:34:49Z

Sorry, @corona10, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 87bd2071c756188b6cd577889fb1682831142ceb 3.7

bedevere-bot · 2019-09-05T00:49:07Z

GH-15687 is a backport of this pull request to the 3.7 branch.

GH-15522) https://bugs.python.org/issue22347 (cherry picked from commit 87bd207) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

@maxking

…of URLs (GH-15522) (GH-15687) https://bugs.python.org/issue22347 (cherry picked from commit 87bd207) https://bugs.python.org/issue22347 Automerge-Triggered-By: @maxking

pythonGH-15522) https://bugs.python.org/issue22347

…oper parsing of URLs (pythonGH-15522)" This reverts commit 87bd207.

…er parsing of URLs (GH-15522)" (GH-16724) This reverts commit 87bd207. https://bugs.python.org/issue38449

…er parsing of URLs (pythonGH-15522)" (pythonGH-16724) This reverts commit 87bd207. https://bugs.python.org/issue38449 (cherry picked from commit 19a3d87) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>

…parsing of URLs (GH-15522) (GH-15687)" This reverts commit 8873bff.

…low oper parsing of URLs (pythonGH-15522)" (pythonGH-16724) This reverts commit 87bd207. https://bugs.python.org/issue38449 (cherry picked from commit 19a3d87) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>

…er parsing of URLs (pythonGH-15522)" (pythonGH-16724) This reverts commit 87bd207. https://bugs.python.org/issue38449

pythonGH-15522) https://bugs.python.org/issue22347

corona10 requested a review from a team as a code owner August 26, 2019 16:04

the-knights-who-say-ni added the CLA signed label Aug 26, 2019

bedevere-bot added the awaiting review label Aug 26, 2019

epicfaace suggested changes Aug 27, 2019

View reviewed changes

Misc/NEWS.d/next/Library/2019-08-27-01-03-26.bpo-22347._TRpYr.rst Outdated Show resolved Hide resolved

Lib/mimetypes.py Show resolved Hide resolved

Lib/test/test_mimetypes.py Show resolved Hide resolved

bedevere-bot added awaiting core review and removed awaiting review labels Aug 27, 2019

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs

ec8c6f7

corona10 force-pushed the bpo-22347 branch from c6be049 to ec8c6f7 Compare August 27, 2019 02:16

corona10 changed the title ~~bpo-22347: Remove urllib.parse._splittype from mimetypes.guess_type.~~ bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs Aug 27, 2019

epicfaace approved these changes Aug 27, 2019

View reviewed changes

maxking reviewed Aug 31, 2019

View reviewed changes

Lib/mimetypes.py Outdated Show resolved Hide resolved

Lib/mimetypes.py Show resolved Hide resolved

maxking requested changes Aug 31, 2019

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels Aug 31, 2019

bpo-22347: Revert import

8766a42

corona10 requested a review from maxking August 31, 2019 20:51

bedevere-bot added awaiting change review and removed awaiting changes labels Sep 3, 2019

maxking approved these changes Sep 5, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Sep 5, 2019

maxking added needs backport to 3.7 labels Sep 5, 2019

maxking added the 🤖 automerge label Sep 5, 2019

miss-islington merged commit 87bd207 into python:master Sep 5, 2019

bedevere-bot removed the awaiting merge label Sep 5, 2019

bedevere-bot removed the needs backport to 3.8 label Sep 5, 2019

miss-islington self-assigned this Sep 5, 2019

corona10 deleted the bpo-22347 branch September 5, 2019 00:38

bedevere-bot removed the needs backport to 3.7 label Sep 5, 2019

miss-islington added a commit that referenced this pull request Sep 5, 2019

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (

6d7a786

GH-15522) https://bugs.python.org/issue22347 (cherry picked from commit 87bd207) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (

3873b01

pythonGH-15522) https://bugs.python.org/issue22347

maxking added a commit to maxking/cpython-1 that referenced this pull request Oct 12, 2019

bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow pr…

78cbde4

…oper parsing of URLs (pythonGH-15522)" This reverts commit 87bd207.

miss-islington pushed a commit that referenced this pull request Oct 12, 2019

bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow op…

19a3d87

…er parsing of URLs (GH-15522)" (GH-16724) This reverts commit 87bd207. https://bugs.python.org/issue38449

maxking added a commit that referenced this pull request Oct 12, 2019

Revert "[3.7] bpo-22347: Update mimetypes.guess_type to allow proper …

455869a

…parsing of URLs (GH-15522) (GH-15687)" This reverts commit 8873bff.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (

8afedbb

pythonGH-15522) https://bugs.python.org/issue22347

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (

f5047f4

pythonGH-15522) https://bugs.python.org/issue22347

vadmium mentioned this pull request Apr 10, 2022

mimetypes.guess_type("//example.com") misinterprets host name as file name #66543

Closed

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 25, 2024

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (

0aa5b2e

pythonGH-15522) https://bugs.python.org/issue22347

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs #15522

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs #15522

corona10 commented Aug 26, 2019 •

edited by miss-islington

Loading

corona10 commented Aug 26, 2019 •

edited

Loading

corona10 commented Aug 27, 2019

epicfaace left a comment

corona10 commented Aug 27, 2019

maxking left a comment

bedevere-bot commented Aug 31, 2019

corona10 commented Aug 31, 2019

corona10 commented Sep 3, 2019

bedevere-bot commented Sep 3, 2019

maxking left a comment •

edited

Loading

miss-islington commented Sep 5, 2019

bedevere-bot commented Sep 5, 2019

miss-islington commented Sep 5, 2019

bedevere-bot commented Sep 5, 2019

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs #15522

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs #15522

Conversation

corona10 commented Aug 26, 2019 • edited by miss-islington Loading

corona10 commented Aug 26, 2019 • edited Loading

corona10 commented Aug 27, 2019

epicfaace left a comment

Choose a reason for hiding this comment

corona10 commented Aug 27, 2019

maxking left a comment

Choose a reason for hiding this comment

bedevere-bot commented Aug 31, 2019

corona10 commented Aug 31, 2019

corona10 commented Sep 3, 2019

bedevere-bot commented Sep 3, 2019

maxking left a comment • edited Loading

Choose a reason for hiding this comment

miss-islington commented Sep 5, 2019

bedevere-bot commented Sep 5, 2019

miss-islington commented Sep 5, 2019

bedevere-bot commented Sep 5, 2019

corona10 commented Aug 26, 2019 •

edited by miss-islington

Loading

corona10 commented Aug 26, 2019 •

edited

Loading

maxking left a comment •

edited

Loading