Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typo] Fix disagreement between value, character, and name #15536

Closed
wants to merge 1 commit into from
Closed

[typo] Fix disagreement between value, character, and name #15536

wants to merge 1 commit into from

Conversation

nicktimko
Copy link

Used to be the hex value and description agreed, and the character was odd-one-out, but now the hex value is the odd-one after 77df9a1.

Used to be the hex value and description agreed, and the character was odd-one-out, but now the hex value is the odd-one after 77df9a1.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 26, 2019
@fbidu
Copy link
Contributor

fbidu commented Aug 26, 2019

It checks out. Nice catch, never would've noticed...

@nicktimko
Copy link
Author

nicktimko commented Aug 26, 2019

@sir-sigurd spotted it, I just did a quick PR.

import unicodedata
for n in range(0x2167, 0x2169):
    print(hex(n), chr(n), unicodedata.name(chr(n)))

# output:
# 0x2167 Ⅷ ROMAN NUMERAL EIGHT
# 0x2168 Ⅸ ROMAN NUMERAL NINE

@corona10
Copy link
Member

I think that @ethanfurman can review this PR well.

@nicktimko
Copy link
Author

Go with #15541, looks more complete.

@nicktimko nicktimko closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants