bpo-34410: Fix a crash in the tee iterator when re-enter it. #15625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
changed the title
RuntimeError is now raised in this case.
serhiy-storchaka
force-pushed
the
tee-reenter-3.8
branch
from
9bfc5ca
to
6bd711c
Compare
serhiy-storchaka
requested review from
1st1,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
ezio-melotti,
gpshead,
gvanrossum,
ilevkivskyi,
methane,
ncoghlan,
pablogsal,
skrah,
terryjreedy,
tiran,
warsaw and
a team
as code owners
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
|
GH-15737 is a backport of this pull request to the 3.8 branch. |
|
GH-15738 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 9, 2019
…ythonGH-15625) RuntimeError is now raised in this case.. (cherry picked from commit 526a014) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-15740 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 9, 2019
miss-islington
added a commit
that referenced
this pull request
Sep 9, 2019
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 9, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…H-15625) RuntimeError is now raised in this case.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…H-15625) RuntimeError is now raised in this case.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…H-15625) RuntimeError is now raised in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuntimeError is now raised in this case.
https://bugs.python.org/issue34410