Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37994: Fix silencing all errors if an attribute lookup fails. #15630

Merged
merged 1 commit into from
Sep 1, 2019
Merged

bpo-37994: Fix silencing all errors if an attribute lookup fails. #15630

merged 1 commit into from
Sep 1, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 31, 2019 •
edited by bedevere-bot
Loading

Only AttributeError should be silenced.

https://bugs.python.org/issue37994

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Aug 31, 2019
@serhiy-storchaka serhiy-storchaka merged commit 41c57b3 into python:master Sep 1, 2019
@serhiy-storchaka serhiy-storchaka deleted the getattr-no-silence-errors branch September 1, 2019 09:03
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 41c57b335330ff48af098d47e379e0f9ba09d233 3.8

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 1, 2019
@serhiy-storchaka
[3.8] bpo-37994: Fix silencing all errors if an attribute lookup fail…
0bbff1b 
…s. (pythonGH-15630)

Only AttributeError should be silenced..
(cherry picked from commit 41c57b3)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-15635 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Sep 1, 2019
@serhiy-storchaka
[3.8] bpo-37994: Fix silencing all errors if an attribute lookup fail…
353053d 
…s. (GH-15630) (GH-15635)

Only AttributeError should be silenced.
(cherry picked from commit 41c57b3)
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@serhiy-storchaka @lisroach
bpo-37994: Fix silencing all errors if an attribute lookup fails. (py…
2e37ae5 
…thonGH-15630)

Only AttributeError should be silenced.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@serhiy-storchaka @DinoV
bpo-37994: Fix silencing all errors if an attribute lookup fails. (py…
44bf0f4 
…thonGH-15630)

Only AttributeError should be silenced.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@serhiy-storchaka @websurfer5
bpo-37994: Fix silencing all errors if an attribute lookup fails. (py…
00a72ee 
…thonGH-15630)

Only AttributeError should be silenced.
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni