Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36324: Apply review comments from Allen Downey #15693

Merged
merged 22 commits into from
Sep 5, 2019
Merged

bpo-36324: Apply review comments from Allen Downey #15693

merged 22 commits into from
Sep 5, 2019

Commits on Sep 4, 2019

  1. Make variable name consistent with other functions (dist -> data)

    @rhettinger
    rhettinger committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    a21ed26 View commit details
    Browse the repository at this point in the history

  2. The word "composite" is ambiguous

    @rhettinger
    rhettinger committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    47ea6e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Clarify how mu and sigma are estimated

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    7e23405 View commit details
    Browse the repository at this point in the history

  2. More precise definition of pdf()

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    6cac6cb View commit details
    Browse the repository at this point in the history

  3. Sync overlap() docs with it docstring

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    e87e053 View commit details
    Browse the repository at this point in the history

  4. Don't imply that the output distribution is normal. Use different see… 

    …d for each variable.
    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    eeea092 View commit details
    Browse the repository at this point in the history

  5. Internally, only use floats

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    64daeed View commit details
    Browse the repository at this point in the history

  6. Clarify what is meant by "mixed types"

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    10df6b0 View commit details
    Browse the repository at this point in the history

  7. Acknowledge the reviewer

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    5f616bc View commit details
    Browse the repository at this point in the history

  8. Drop mention of statistical efficiency 

    Reviewer comment: "From a statistics point of view, the difference in efficiency
between mean and median is not important, it's not worth explaining here, and it
creates confusion with computational efficiency."
    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    ef1b4a6 View commit details
    Browse the repository at this point in the history

  9. Remove confusing comment on accuracy

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    0191a63 View commit details
    Browse the repository at this point in the history

  10. Clarify the fmean() and geometric_mean() accept iterators

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    b8e2cee View commit details
    Browse the repository at this point in the history

  11. Explain what a geometric mean is

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    ad20665 View commit details
    Browse the repository at this point in the history

  12. "Too high" was too vague

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    bcfa71c View commit details
    Browse the repository at this point in the history

  13. Clarity that multiple modes means having the same frequency

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    cb81866 View commit details
    Browse the repository at this point in the history

  14. Clarify that the uniqueness is relative to the other functions in the… 

    … package
    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    38c36cc View commit details
    Browse the repository at this point in the history

  15. mu is not required to be the mean

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    876d642 View commit details
    Browse the repository at this point in the history

  16. Non-mean values of mu are allowed

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1ff9005 View commit details
    Browse the repository at this point in the history

  17. Clarify that sequences or iterators are allowed. Sync-up docstring

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    3f9c1f8 View commit details
    Browse the repository at this point in the history

  18. Be specific about what is meant by "representative"

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    5d4cd03 View commit details
    Browse the repository at this point in the history

  19. Fix doctest markup

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    75b2167 View commit details
    Browse the repository at this point in the history

  20. More explanation for overlap()

    @rhettinger
    rhettinger committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    2eb8a59 View commit details
    Browse the repository at this point in the history