-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38041: Refine IDLE Shell restart lines. #15709
Conversation
Pull restart line calculation into a separate module function. Add tests that currently pass.
Tal, I believe that this is ready and expect to merge it tomorrow, as indicated by the idlelib news entry. But take a look if you want and have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change overall. I made a few comments but nothing major.
Co-Authored-By: Tal Einat <taleinat+github@gmail.com>
Co-Authored-By: Tal Einat <taleinat+github@gmail.com>
I am up much later than I should be. Will finish revisions after sleeping. Thank you for the improvements. |
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
GH-15719 is a backport of this pull request to the 3.8 branch. |
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
GH-15720 is a backport of this pull request to the 3.7 branch. |
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user. (cherry picked from commit 38da805) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.
https://bugs.python.org/issue38041