bpo-36018: Address more reviewer feedback #15733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry, @rhettinger, I could not cleanly backport this to |
rhettinger
added a commit
to rhettinger/cpython
that referenced
this pull request
Sep 9, 2019
|
GH-15734 is a backport of this pull request to the 3.8 branch. |
rhettinger
added a commit
that referenced
this pull request
Sep 9, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple the quantiles() function from NormalDist, giving each a cleaner API. The function now has a simpler API because it only takes a data argument instead of data or a distribution. The method now has a better API without a confusing and ignored "method" parameter". The method is also directly discoverable from a NormalDist instance using
dir(nd).Added median() and mode() methods, making the Dist API more generic so it can be applied to other, possibly asymmetric distributions.