-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36018: Address more reviewer feedback #15733
Conversation
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
I'm having trouble backporting to |
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, @rhettinger, I could not cleanly backport this to |
GH-15734 is a backport of this pull request to the 3.8 branch. |
Decouple the quantiles() function from NormalDist, giving each a cleaner API. The function now has a simpler API because it only takes a data argument instead of data or a distribution. The method now has a better API without a confusing and ignored "method" parameter". The method is also directly discoverable from a NormalDist instance using
dir(nd)
.Added median() and mode() methods, making the Dist API more generic so it can be applied to other, possibly asymmetric distributions.