Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-38317: Fix PyConfig.warnoptions priority (GH-16478) #16479

Merged
merged 1 commit into from
Sep 29, 2019
Merged

[3.8] bpo-38317: Fix PyConfig.warnoptions priority (GH-16478) #16479

merged 1 commit into from
Sep 29, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 29, 2019 •
edited by bedevere-bot
Loading

Fix warnings options priority: PyConfig.warnoptions has the highest
priority, as stated in the PEP 587.

  • Document options order in PyConfig.warnoptions documentation.
  • Make PyWideStringList_INIT macro private: replace "Py" prefix
    with "_Py".
  • test_embed: add test_init_warnoptions().
    (cherry picked from commit fb4ae15)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue38317

@vstinner @miss-islington
bpo-38317: Fix PyConfig.warnoptions priority (pythonGH-16478)
2fbe6ee 
Fix warnings options priority: PyConfig.warnoptions has the highest
priority, as stated in the PEP 587.

* Document options order in PyConfig.warnoptions documentation.
* Make PyWideStringList_INIT macro private: replace "Py" prefix
  with "_Py".
* test_embed: add test_init_warnoptions().
(cherry picked from commit fb4ae15)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot bedevere-bot mentioned this pull request Sep 29, 2019
Merged
vstinner
vstinner approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c9ed9e6 into python:3.8 Sep 29, 2019
@miss-islington miss-islington deleted the backport-fb4ae15-3.8 branch September 29, 2019 23:58
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot