bpo-29438: fixed use-after-free in key sharing dict #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patch for Python 3.5 is slightly differ from this PR. |
methane
force-pushed
the
bpo29438/fix-dict-useafterfree
branch
from
c38d9fe to
2dd62f6
Compare
zhangyangyu
reviewed
Feb 11, 2017
Objects/dictobject.c
Outdated
| @@ -4352,15 +4352,18 @@ _PyObjectDict_SetItem(PyTypeObject *tp, PyObject **dictptr, | |||
| } | |||
| if (value == NULL) { | |||
| res = PyDict_DelItem(dict, key); | |||
| if (cached != ((PyDictObject *)dict)->ma_keys) { | |||
| // key sharing dict doesn't allow deletion. | |||
There was a problem hiding this comment.
Just as I said this is somewhat misleading and it's better to make it clear.
methane
force-pushed
the
bpo29438/fix-dict-useafterfree
branch
from
2dd62f6 to
bf8bd7e
Compare
Codecov Report@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
+ Hits 289088 289095 +7
+ Misses 61860 61853 -7Continue to review full report at Codecov.
|
zhangyangyu
approved these changes
Feb 11, 2017
methane
referenced
this pull request
in methane/cpython
Feb 12, 2017
paulmon
added a commit
to paulmon/cpython
that referenced
this pull request
Jan 10, 2019
Win arm32 master
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
The `html_url` field takes us to the actual comment on GitHub. `url` field took us to an API JSON response.
nanjekyejoannah
added a commit
to nanjekyejoannah/cpython
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.