Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and segfaults #18640

Merged
merged 4 commits into from
Nov 28, 2022
Merged

bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and segfaults #18640

merged 4 commits into from
Nov 28, 2022

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Feb 24, 2020 •
edited by bedevere-bot
Loading

farazs-github pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Issue python#18640: MINGW: generalization of posix build in distutils…
d9d47df 
…/sysconfig.py
@iritkatriel
Copy link
Member

@ZackerySpytz This has merge conflicts now.

@kumaraditya303 kumaraditya303 added the type-bug An unexpected behavior, bug, or error label Nov 27, 2022
kumaraditya303
kumaraditya303 approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

❯ ./python.bat -m test -R 3:3 test_io
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_io
beginning 6 repetitions
123456
......
test_io passed in 2 min 45 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 2 min 45 sec
Tests result: SUCCESS

@kumaraditya303 kumaraditya303 self-assigned this Nov 27, 2022
@kumaraditya303 kumaraditya303 merged commit 53eef27 into python:main Nov 28, 2022
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @ZackerySpytz and @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 53eef27133c1da395b3b4d7ce0ab1d5b743ffb41 3.11

@miss-islington
Copy link
Contributor

Sorry, @ZackerySpytz and @kumaraditya303, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 53eef27133c1da395b3b4d7ce0ab1d5b743ffb41 3.10

@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Nov 28, 2022
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @ZackerySpytz and @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 53eef27133c1da395b3b4d7ce0ab1d5b743ffb41 3.11

@bedevere-bot
Copy link

GH-99841 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 28, 2022
kumaraditya303 pushed a commit to kumaraditya303/cpython that referenced this pull request Nov 28, 2022
@ZackerySpytz @kumaraditya303
bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and segfaults (
ce6949a 
python#18640)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
(cherry picked from commit 53eef27)
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Nov 28, 2022
@kumaraditya303 @ZackerySpytz
[3.11] bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and s…
8b87eb3 
…egfaults (pythonGH-18640)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 53eef27)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@kumaraditya303 kumaraditya303 mentioned this pull request Nov 28, 2022
Merged
@bedevere-bot
Copy link

GH-99842 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 28, 2022
kumaraditya303 pushed a commit to kumaraditya303/cpython that referenced this pull request Nov 28, 2022
@ZackerySpytz @kumaraditya303
[3.10] bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and s…
9031332 
…egfaults (pythonGH-18640)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 53eef27)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
kumaraditya303 pushed a commit to kumaraditya303/cpython that referenced this pull request Nov 28, 2022
@ZackerySpytz @kumaraditya303
[3.10] bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and s…
08a2828 
…egfaults (pythonGH-18640)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 53eef27)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
kumaraditya303 added a commit that referenced this pull request Nov 28, 2022
@kumaraditya303
[3.11] bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and s…
6f658dd 
…egfaults (GH-18640) (#99841)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

(cherry picked from commit 53eef27)
kumaraditya303 added a commit that referenced this pull request Nov 28, 2022
@kumaraditya303 @ZackerySpytz
[3.10] bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and s… (
a851797 
#99842)

[3.10] bpo-31718: Fix io.IncrementalNewlineDecoder SystemErrors and segfaults (GH-18640)

Co-authored-by: Oren Milman <orenmn@gmail.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>.
(cherry picked from commit 53eef27)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@orenmn orenmn mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

@kumaraditya303 kumaraditya303

Labels
topic-IO type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ZackerySpytz @iritkatriel @miss-islington @bedevere-bot @serhiy-storchaka @kumaraditya303 @the-knights-who-say-ni @ezio-melotti