Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39573: Make Py_IS_TYPE take const args. Add _PyObject_CAST_CONST. #18799

Merged
merged 1 commit into from
Mar 6, 2020
Merged

bpo-39573: Make Py_IS_TYPE take const args. Add _PyObject_CAST_CONST. #18799

merged 1 commit into from
Mar 6, 2020

Conversation

petdance
Copy link
Contributor

@petdance petdance commented Mar 6, 2020 •
edited by bedevere-bot
Loading

As the final part of the Py_IS_TYPE conversion:

  • Make Py_IS_TYPE take const arguments
  • Make new macro _PyObject_CAST_CONST

https://bugs.python.org/issue39573

@petdance petdance mentioned this pull request Mar 6, 2020
Closed
@petdance
Copy link
Contributor Author

petdance commented Mar 6, 2020

Attn: @vstinner

vstinner
vstinner approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked for compiler warnings on Windows, macOS and Linux (clang and GCC). I didn't notice any new warning.

@vstinner vstinner merged commit 8767ce9 into python:master Mar 6, 2020
This was referenced Mar 6, 2020
Closed
Merged
@petdance petdance deleted the bpo-39573-D branch March 6, 2020 16:43
@vstinner vstinner mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petdance @vstinner @the-knights-who-say-ni @bedevere-bot