Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-84556: slightly improved the wording for os.getgrouplist #19702

Merged
merged 2 commits into from
Apr 15, 2022
Merged

gh-84556: slightly improved the wording for os.getgrouplist #19702

merged 2 commits into from
Apr 15, 2022

Conversation

woodfighter
Copy link
Contributor

@woodfighter woodfighter commented Apr 24, 2020 •
edited by JelleZijlstra
Loading

The documentation for os.getgrouplist potentially read like it returned all groups a user belongs to but it potentially doesn't.

#84556

https://bugs.python.org/issue40376

@woodfighter
bpo-40376: slightly improved the wording for os.getgrouplist
45dfb78 
The documentation for os.getgrouplist potentially read like it
returned all groups a user belongs to but it potentially doesn't.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 24, 2020
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@woodfighter

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@aeros aeros self-requested a review April 26, 2020 02:03
@JelleZijlstra JelleZijlstra self-assigned this Apr 14, 2022
@JelleZijlstra JelleZijlstra changed the title bpo-40376: slightly improved the wording for os.getgrouplist gh-84556: slightly improved the wording for os.getgrouplist Apr 14, 2022
@JelleZijlstra
Copy link
Member

Thanks for your contribution, and sorry it had to wait for so long!

@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 14, 2022
@JelleZijlstra JelleZijlstra merged commit bd26ef5 into python:main Apr 15, 2022
@miss-islington
Copy link
Contributor

Thanks @woodfighter for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 15, 2022
@woodfighter @miss-islington
bpo-40376: slightly improved the wording for os.getgrouplist (pythonG…
2fb283a 
…H-19702)

The documentation for os.getgrouplist potentially read like it
returned all groups a user belongs to but it potentially doesn't.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit bd26ef5)

Co-authored-by: Jens Holzkämper <jens@holzkaemper.berlin>
@bedevere-bot
Copy link

GH-91556 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels Apr 15, 2022
@bedevere-bot
Copy link

GH-91557 is a backport of this pull request to the 3.9 branch.

@ambv ambv added the needs backport to 3.10 only security fixes label Apr 15, 2022
@miss-islington
Copy link
Contributor

Thanks @woodfighter for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

ambv pushed a commit that referenced this pull request Apr 15, 2022
@miss-islington @woodfighter
bpo-40376: slightly improved the wording for os.getgrouplist (GH-19702)…
2c03470 
… (GH-91557)

The documentation for os.getgrouplist potentially read like it
returned all groups a user belongs to but it potentially doesn't.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit bd26ef5)

Co-authored-by: Jens Holzkämper <jens@holzkaemper.berlin>
@woodfighter woodfighter mannequin mentioned this pull request Apr 10, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @woodfighter @hello-adam
bpo-40376: slightly improved the wording for os.getgrouplist (pythonG…
faa477e 
…H-19702) (pythonGH-91557)

The documentation for os.getgrouplist potentially read like it
returned all groups a user belongs to but it potentially doesn't.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit bd26ef5)

Co-authored-by: Jens Holzkämper <jens@holzkaemper.berlin>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@aeros aeros Awaiting requested review from aeros

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir needs backport to 3.10 only security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@woodfighter @the-knights-who-say-ni @JelleZijlstra @miss-islington @bedevere-bot @ambv @aeros