Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29587: Remove the exc_value NULL check in _gen_throw() #19877

Merged
merged 2 commits into from
May 3, 2020
Merged

bpo-29587: Remove the exc_value NULL check in _gen_throw() #19877

merged 2 commits into from
May 3, 2020

Conversation

cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented May 3, 2020 •
edited
Loading

This is another follow-up to PR #19823, removing the check that exc_value isn't NULL prior to calling _PyErr_ChainExceptions(). This makes it so that exception chaining can occur in more cases.

https://bugs.python.org/issue29587

@cjerdonek cjerdonek requested a review from 1st1 as a code owner May 3, 2020 04:28
gvanrossum
gvanrossum approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck!

@cjerdonek
Copy link
Member Author

Thanks! :) I'll be posting a comment on the issue with what I found..

@cjerdonek cjerdonek merged commit 21893fb into python:master May 3, 2020
@cjerdonek cjerdonek deleted the issue-29587-allow-null-values branch May 3, 2020 07:08
This was referenced May 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjerdonek @gvanrossum @the-knights-who-say-ni @bedevere-bot