Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] [3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (GH-20100) #20101

Merged
merged 1 commit into from
May 15, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 15, 2020

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)

Signed-off-by: Filipe Laíns lains@archlinux.org
(cherry picked from commit 75d7257)

Signed-off-by: Filipe Laíns lains@archlinux.org
(cherry picked from commit 6a78589)

Co-authored-by: Filipe Laíns filipe.lains@gmail.com
Co-authored-by: Filipe Laíns lains@archlinux.org
(cherry picked from commit 07bd5cf)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue40548

…ythonGH-20100)

* bpo-40548: Always run GitHub action, even on doc PRs (pythonGH-19981)

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)

* bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (pythonGH-19983)

Signed-off-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit 75d7257)

* bpo-40548: github actions: pass the changes check on no source changes (pythonGH-20097)

Signed-off-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit 6a78589)

Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
Co-authored-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit 07bd5cf)

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot. I checked that wit the cherry-pick, 3.7 and master have the same configuration. master also has "push" configuration which is not needed for 3.7 if I understood correctly. (Same difference in 3.8.)

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6ad51a1 into python:3.7 May 15, 2020
@miss-islington miss-islington deleted the backport-07bd5cf-3.7 branch May 15, 2020 03:46
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants