Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41338: Fix warnings in test_decimal #21542

Merged
merged 3 commits into from
Jul 20, 2020
Merged

bpo-41338: Fix warnings in test_decimal #21542

merged 3 commits into from
Jul 20, 2020

Conversation

methane
Copy link
Member

@methane methane commented Jul 19, 2020 •
edited by bedevere-bot
Loading

@methane methane added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir skip news labels Jul 19, 2020
@methane methane requested review from rhettinger and skrah as code owners July 19, 2020 08:03
@methane
Copy link
Member Author

methane commented Jul 19, 2020

@serhiy-storchaka What do you think about suppress DeprecationWarning in requires_legacy_unicode_capi decorator?

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka What do you think about suppress DeprecationWarning in requires_legacy_unicode_capi decorator?

I think it is a good idea. Actually I have wrote a PR #21543 that implements it simultaneously with you. 😉

serhiy-storchaka
serhiy-storchaka approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It is up to you, mark with ignore_warnings individual tests or change requires_legacy_unicode_capi.

@skrah
Copy link
Contributor

skrah commented Jul 19, 2020

Actually, we could delete this test if it's too much trouble. It has run for several years and the code won't change.

@methane methane merged commit 902356a into python:master Jul 20, 2020
@methane methane deleted the fix-decimal-warnings branch July 20, 2020 03:02
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@methane @arun-mani-j
bpo-41338: Fix DeprecationWarning in tests (pythonGH-21542)
4e21dea
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@methane @shihai1991
bpo-41338: Fix DeprecationWarning in tests (pythonGH-21542)
36a8204
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@methane @shihai1991
bpo-41338: Fix DeprecationWarning in tests (pythonGH-21542)
5a745bb
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@methane
bpo-41338: Fix DeprecationWarning in tests (pythonGH-21542)
a140bb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrah skrah skrah approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methane @serhiy-storchaka @skrah @the-knights-who-say-ni @bedevere-bot