Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subprocess: Add escape_wildcard parameter for program don't want the wildcard matched files #22590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lygstate
Copy link

@lygstate lygstate commented Oct 7, 2020

According to https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?redirectedfrom=MSDN#wildcard-expansion,
the default msvcrt will automatically using wildcard to matching files, and sometimes it's not the program wanted, so provide a
option to escape it.

Signed-off-by: Yonggang Luo luoyonggang@gmail.com

…wildcard matched files

According to https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?redirectedfrom=MSDN#wildcard-expansion,
the default msvcrt will automatically using wildcard to matching files, and sometimes it's not the program wanted, so provide a
option to escape it.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@lygstate lygstate requested a review from gpshead as a code owner October 7, 2020 18:58
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@lygstate

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@lygstate
Copy link
Author

lygstate commented Oct 7, 2020

The real cause are git, maybe doesn't need fix here msys2/MSYS2-packages#2176, maybe still
worth in some condition to consistence between different platform

@lygstate lygstate reopened this Oct 8, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@CoolCat467
Copy link

@lygstate CLA finally marked as signed

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants