Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40522: Use PyThreadState_Get() in decimal #24597

Closed
wants to merge 1 commit into from
Closed

bpo-40522: Use PyThreadState_Get() in decimal #24597

wants to merge 1 commit into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 20, 2021 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner February 20, 2021 06:24
@corona10 corona10 requested a review from rhettinger as a code owner February 20, 2021 06:24
@vstinner
Copy link
Member

In commit 6207810, I wanted to clarify that the function is used in practice rather than the macro in public Python header files. But in _decimal, I suggest either to leave it unchanged, or switch to faster _PyThreadState_GET() which is always inlined.

@corona10
Copy link
Member Author

@vstinner Got it, Okay let's leave it to be unchanged ;)

@corona10 corona10 closed this Feb 20, 2021
@corona10 corona10 deleted the bpo-40522-decimal branch February 20, 2021 13:03
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot