Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] bpo-11975: Fixed 2.7 docs - links to list, backported from python3.x #2518

Merged
merged 1 commit into from
Jun 30, 2017
Merged

[2.7] bpo-11975: Fixed 2.7 docs - links to list, backported from python3.x #2518

merged 1 commit into from
Jun 30, 2017

Conversation

dmitrytokarev
Copy link

Fixing links in Python 2.7 docs as now docs have broken links to list():
https://docs.python.org/2.7/library/functions.html

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@dmitrytokarev dmitrytokarev changed the title Fixed 2.7 docs - links to list, backported from python3.x issue11975: Fixed 2.7 docs - links to list, backported from python3.x Jun 30, 2017
@dmitrytokarev dmitrytokarev changed the title issue11975: Fixed 2.7 docs - links to list, backported from python3.x [2.7] bpo-11975: Fixed 2.7 docs - links to list, backported from python3.x Jun 30, 2017
dmitrytokarev referenced this pull request Jun 30, 2017
@serhiy-storchaka
[2.7] bpo-30380: Fix Sphinx 1.6.1 warnings. (GH-1613) (#1616)
b8b9f95 
* Use explicit numbering for footnotes referred by explicit number.
* Fix literal strings formatting in howto/urllib2.rst.
* Add `:noindex:` to duplicated definition of list.
* Update susp-ignored.csv for reference/expressions.rst.
(cherry picked from commit d97b7dc)
serhiy-storchaka
serhiy-storchaka approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The patch that I have just written is exactly the same.

Thank you for your report and patch Dmitry!

@serhiy-storchaka serhiy-storchaka added trivial docs Documentation in the Doc dir labels Jun 30, 2017
@serhiy-storchaka serhiy-storchaka merged commit 58bb0d8 into python:2.7 Jun 30, 2017
@dmitrytokarev
Copy link
Author

@serhiy-storchaka just out of curiosity how long does it take to publish docs?

@dmitrytokarev dmitrytokarev deleted the fix-2.7-docs-links-to-list branch June 30, 2017 19:11
@dmitrytokarev dmitrytokarev mentioned this pull request Jun 30, 2017
Merged
@serhiy-storchaka
Copy link
Member

I don't know, but online docs already are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrytokarev @the-knights-who-say-ni @serhiy-storchaka