bpo-43798: Add source location attributes to alias. #25324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
reviewed
Apr 9, 2021
There was a problem hiding this comment.
Hey @msuozzo and thanks for the PR! 🎉 I've left a comment that needs addressing. Also, please add a NEWS blurb or, in case you don't know how, let me know so that I can add one for you. Other than that, the PR looks good, although I'd like to see some more discussion on bpo before approving this.
|
This also needs a news entry. You can add one easily here |
pablogsal
reviewed
Apr 10, 2021
Misc/NEWS.d/next/Core and Builtins/2021-04-10-00-01-43.bpo-43798.p_nJFM.rst
Outdated
Show resolved
Hide resolved
pablogsal
approved these changes
Apr 10, 2021
lysnikolaou
approved these changes
Apr 10, 2021
|
Thanks again for the PR, @msuozzo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43798