Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44279: revert 'exceptions are raised' back to 'exceptions occur' #26492

Merged
merged 1 commit into from
Jun 4, 2021
Merged

bpo-44279: revert 'exceptions are raised' back to 'exceptions occur' #26492

merged 1 commit into from
Jun 4, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 2, 2021 •
edited by bedevere-bot
Loading

The previous commit had some makrup changes that are worth keeping, so I'm not reverting the whole change.

https://bugs.python.org/issue44279

@iritkatriel iritkatriel requested a review from 1st1 as a code owner June 2, 2021 22:24
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 2, 2021
@iritkatriel iritkatriel requested review from rhettinger and removed request for 1st1 June 2, 2021 22:24
@rhettinger rhettinger self-assigned this Jun 4, 2021
@rhettinger
Copy link
Contributor

Please also revert one of the two bits of mark-up for the with-statement. We typically provide a single link and don't spam our entries with a link every time an interesting concept is mentioned.

@iritkatriel
Copy link
Member Author

Please also revert one of the two bits of mark-up for the with-statement. We typically provide a single link and don't spam our entries with a link every time an interesting concept is mentioned.

They both have ! so I think they won't be links.

@iritkatriel iritkatriel merged commit dda9ecb into python:main Jun 4, 2021
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
@iritkatriel @miss-islington
bpo-44279: revert 'exceptions are raised' back to 'exceptions occur' (p…
05930c5 
…ythonGH-26492)

(cherry picked from commit dda9ecb)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

GH-26538 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 4, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
@iritkatriel @miss-islington
bpo-44279: revert 'exceptions are raised' back to 'exceptions occur' (p…
4d0d9c2 
…ythonGH-26492)

(cherry picked from commit dda9ecb)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

GH-26539 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 4, 2021
@iritkatriel iritkatriel deleted the bpo-44279 branch June 4, 2021 22:08
@iritkatriel iritkatriel restored the bpo-44279 branch June 4, 2021 22:08
@iritkatriel iritkatriel deleted the bpo-44279 branch June 4, 2021 22:08
iritkatriel added a commit that referenced this pull request Jun 4, 2021
@miss-islington @iritkatriel
bpo-44279: revert 'exceptions are raised' back to 'exceptions occur' (G…
ea298e1 
…H-26492) (GH-26539)

(cherry picked from commit dda9ecb)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Jun 4, 2021
@miss-islington @iritkatriel
bpo-44279: revert 'exceptions are raised' back to 'exceptions occur' (G…
1065ba6 
…H-26492) (GH-26538)

(cherry picked from commit dda9ecb)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees

@rhettinger rhettinger

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @rhettinger @miss-islington @bedevere-bot @the-knights-who-say-ni