-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-44967: pydoc: return non-zero exit code when query is not found #27868
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Hi @gpanders, thanks for your contribution! I'm assuming you filled out the CLA and we're waiting for it to clear. In the mean time, your PR will definitely need updated tests and a NEWS entry. |
7e61241
to
383032c
Compare
The CLA is signed and I have a test written, but I'm not sure where to put the NEWS file. |
It's probably easiest to put a NEWS entry using this app: |
Thanks! Blurb added. |
I think this PR may have caused #98374. |
https://bugs.python.org/issue44967