-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.9] bpo-45097: Remove incorrect deprecation warnings in asyncio. #28153
Merged
serhiy-storchaka
merged 2 commits into
python:3.9
from
serhiy-storchaka:asyncio-deprecation-warnings-3.9
Sep 4, 2021
Merged
[3.9] bpo-45097: Remove incorrect deprecation warnings in asyncio. #28153
serhiy-storchaka
merged 2 commits into
python:3.9
from
serhiy-storchaka:asyncio-deprecation-warnings-3.9
Sep 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation warnings about the loop argument were incorrectly emitted in cases when the loop argument was used inside the asyncio library, not from user code.
serhiy-storchaka
force-pushed
the
asyncio-deprecation-warnings-3.9
branch
from
September 4, 2021 13:17
c428a51
to
0d0aa39
Compare
asvetlov
approved these changes
Sep 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when all checks are green. Thanks!
serhiy-storchaka
commented
Sep 4, 2021
Misc/NEWS.d/next/Library/2021-09-04-13-10-25.bpo-45097.5J4IC-.rst
Outdated
Show resolved
Hide resolved
serhiy-storchaka
changed the title
bpo-45097: Remove incorrect deprecation warnings in asyncio.
[3.9] bpo-45097: Remove incorrect deprecation warnings in asyncio.
Sep 4, 2021
jonringer
added a commit
to jonringer/nixpkgs
that referenced
this pull request
Sep 13, 2021
Will eventually be fixed by: python/cpython#28153 on next cpython release
StephenWithPH
pushed a commit
to StephenWithPH/nixpkgs
that referenced
this pull request
Sep 24, 2021
Will eventually be fixed by: python/cpython#28153 on next cpython release
mweinelt
pushed a commit
to mweinelt/nixpkgs
that referenced
this pull request
Oct 3, 2021
Will eventually be fixed by: python/cpython#28153 on next cpython release
a-feld
added a commit
to a-feld/pywreck
that referenced
this pull request
Oct 7, 2021
Python v3.9.7 loop.create_server internally uses the loop argument to call gather, resulting in a warning being generated. https://github.com/python/cpython/blob/v3.9.7/Lib/asyncio/base_events.py#L1460 This has been fixed, but not yet released: python/cpython#28153
Is there a planned tagging of this? It's quite the problem, and we could definitely use this change as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warnings about the loop argument were incorrectly emitted
in cases when the loop argument was used inside the asyncio library,
not from user code.
https://bugs.python.org/issue45097