bpo-45834: Move runtime 'except:' check to the parser #29625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Nov 18, 2021
|
LGTM based on the tests but I’m not a good reviewer for the parser. |
isidentical
reviewed
Nov 21, 2021
| if (!handler->v.ExceptHandler.type && i < n-1) { | ||
| return compiler_error(c, "default 'except:' must be last"); | ||
| } | ||
| assert(handler->v.ExceptHandler.type || i >= n-1); |
There was a problem hiding this comment.
Do we also need to add this check to the AST validator? (since it might lead to crashes when compiling manually crafted AST objects).
There was a problem hiding this comment.
Yup, what makes me think that maybe this change is not worth it because I find this PR much more complex than what we currently have
There was a problem hiding this comment.
Before making a decision about this PR, could you please look at the parser change for except* on #29581 ?
|
Let's close this if it's not worth doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45834