Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45847: Don't override user overrides for CFLAGS/LIBS (GH-29967) #29967

Merged
merged 5 commits into from
Dec 8, 2021
Merged

bpo-45847: Don't override user overrides for CFLAGS/LIBS (GH-29967) #29967

merged 5 commits into from
Dec 8, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Dec 7, 2021 •
edited
Loading

I'm deliberately using a more verbose approach here to make the code more understandable and easier to grep.

https://bugs.python.org/issue45847

@tiran tiran requested a review from erlend-aasland December 7, 2021 17:44
@tiran tiran added the skip news label Dec 7, 2021
@tiran tiran force-pushed the bpo-45847-fallback branch from b100d69 to 75d04da Compare December 7, 2021 17:46
erlend-aasland
erlend-aasland reviewed Dec 7, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
erlend-aasland
erlend-aasland reviewed Dec 7, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
@tiran tiran force-pushed the bpo-45847-fallback branch from 9e08520 to 4cc2fe1 Compare December 8, 2021 08:36
@tiran tiran marked this pull request as ready for review December 8, 2021 08:37
erlend-aasland
erlend-aasland reviewed Dec 8, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit f02fae3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@tiran tiran changed the title bpo-45847: Don't override user overrides for CFLAGS/LIBS bpo-45847: Don't override user overrides for CFLAGS/LIBS (GH-29967) Dec 8, 2021
@tiran tiran merged commit 0461c68 into python:main Dec 8, 2021
@tiran tiran deleted the bpo-45847-fallback branch December 8, 2021 10:52
@tiran tiran mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @bedevere-bot @erlend-aasland @the-knights-who-say-ni