-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45292: [PEP-654] exception groups and except* documentation #30158
Conversation
@willingc Is there anyone from the documentation experts who may be interested in helping with this? |
@Fidget-Spinner Are you available to help here? |
@iritkatriel I'm happy to help if @Fidget-Spinner is unavailable. I'm assuming you wish for some help to resolve whatever is causing the doc build to error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Irit, this looks good. Looking into the keyword errors.
Thank you. Not just the formatting error, also a fresh reader who can see if it’s clear and consistent with the documentation style, and whether things are where they belong and at the right level of detail. |
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@iritkatriel I think the tone and content are well done. I need to drop for the evening but feel free to merge if the build error resolves. Ping me in the morning if you get stuck on that. Thanks! |
Hi @iritkatriel, you need to create a label/anchor (I forgot the term) for For some reason, keyword labels must be placed preceding a title, even though rST supports arbitrary anchors normally. See https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-ref for more info. |
Thank you @willingc and @Fidget-Spinner , it's looking good now. I will give @gvanrossum and @1st1 and anyone else a chance to review before merging. There isn't any rush with this - the early users we have now already read the PEP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is the first time I'm reading about PEP 654 in more detail, and I did not realize it was this powerful!
Speaking from the perspective of a newbie, I understood what you wrote. The tutorial and language reference is very clear to me.
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
…that rest is not exactly subgroup(not condition)
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
I'm happy to take comments related to |
Shall I merge this? It might be nice to have the documentation there when except* is released in the next alpha. |
@iritkatriel Prior to merging, can you recap any outstanding next actions needed in a message here. Thanks! |
I believe this PR now describes the way exception groups and except* work, and is consistent with PEP654. The new |
I could also split out the |
Yeah, let's keep |
Thank you everyone! The notes section is in this draft PR #30441. |
https://bugs.python.org/issue45292