-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46119: Update bundled pip to 21.3.1 and setuptools to 59.7.0 #30178
Conversation
cc @pablogsal |
Hi @kumaraditya303. Thanks for your PR. Unfortunately I cannot merge this PR directly as I need to Will try to check this as soon as possible if @ambv doesn't do it first :) |
I am thinking about automating this step in cpython with a github action which runs every let's say a week or so and creates a PR with the latest pip and setuptools as manually it takes longer for pip to be updated in the repo and that will be more secure and fast rather than someone doing it. Let me know your thoughts on this @pablogsal |
That would be a lot of unnecessary churns. We only need to update these pre-release, so technically once a month is ok. On the other hand this can be something done in the release itself. Maybe @ambv has some ideas here |
We can add a unit test that gets hashes of pip and setuptools from Warehouse’s JSON API (e.g., https://pypi.org/pypi/pip/21.3.1/json) and compares it to hashes of the vendored files. |
Ah, that would certainly be interesting! |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straight forward.
Thanks for the review but this is not ready to merge, there are now newer pip and setuptools versions (and possibly a new pip this week). Plus see earlier discussion on how to do this in a way to better fit with the release and avoid churn. |
Closing as this is outdated now. |
Done in #31885 |
https://bugs.python.org/issue46119