Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46205: exit if no workers are alive in runtest_mp #30470

Merged
merged 2 commits into from
Jan 11, 2022
Merged

bpo-46205: exit if no workers are alive in runtest_mp #30470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a459729
bpo-46205: exit if no workers are alive in runtest_mp
colesbury Oct 16, 2020
5827e28
Refactor _get_result() based on @corona10's suggestion.
colesbury Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/libregrtest/runtest_mp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,8 @@ def _get_result(self) -> QueueOutput | None:
running = get_running(self.workers)
if running and not self.ns.pgo:
self.log('running: %s' % ', '.join(running))
elif not any(worker.is_alive() for worker in self.workers):
colesbury marked this conversation as resolved.
Show resolved Hide resolved
return None

def display_result(self, mp_result: MultiprocessResult) -> None:
result = mp_result.result
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2022-01-07-14-06-12.bpo-46205.dnc2OC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix hang in runtest_mp due to race condition