-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46829: Deprecate passing a message into Future.cancel() and Task.cancel() #31840
Conversation
Please hold off on merging this until we've come to some kind of agreement on whether to deprecate |
Also, if we do this we should add deprecation markup to the docs. Search for 'method:: cancel' in asyncio-future.rst and asyncio-task.rst. Also there's a note at the very bottom of asyncio-future.rst about the difference between asyncio.Future.cancel and concurrent.futures.Future.cancel that should be deprecated. |
Forgot about docs, thanks. |
I've updated the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how long to wait for @cjerdonek to respond or agree.
@cjerdonek would you comment on this pull request, please? |
I'm just going to merge this. @cjerdonek, if you have a convincing argument to keep this, we can always revert this PR. |
At the core dev sprint we discussed this and decided to revert this. I'm aiming to get the reversal into 3.11. |
https://bugs.python.org/issue46829