Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45979: Fix Tkinter tests with old Tk #31938

Merged
merged 1 commit into from
Mar 16, 2022
Merged

bpo-45979: Fix Tkinter tests with old Tk #31938

merged 1 commit into from
Mar 16, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 16, 2022 •
edited by bedevere-bot
Loading

Only fix for Tk version >= 8.5.12.

https://bugs.python.org/issue45979

@serhiy-storchaka
bpo-45979: Fix Tkinter tests with old Tk
c6f0e57 
Only fix for Tk version >= 8.5.12.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 16, 2022
@serhiy-storchaka serhiy-storchaka merged commit dbbe4d2 into python:main Mar 16, 2022
@serhiy-storchaka serhiy-storchaka deleted the test_tk5 branch March 16, 2022 17:43
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
@serhiy-storchaka @miss-islington
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (pythonGH-31938)
e3d8bb0 
(cherry picked from commit dbbe4d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
@serhiy-storchaka @miss-islington
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (pythonGH-31938)
5d97d96 
(cherry picked from commit dbbe4d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 16, 2022
@bedevere-bot
Copy link

GH-31940 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 16, 2022
@bedevere-bot
Copy link

GH-31939 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Mar 17, 2022
@miss-islington @serhiy-storchaka
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
612019e 
(cherry picked from commit dbbe4d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.9 only security fixes label Mar 17, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dbbe4d2d0075fa0e95b069fb4780d79aae3514c7 3.9

@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes and removed needs backport to 3.9 only security fixes labels Mar 17, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland mentioned this pull request Mar 17, 2022
Merged
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Mar 18, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 18, 2022
@bedevere-bot
Copy link

GH-31972 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2022
@serhiy-storchaka @miss-islington
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (pythonGH-31938)
e37d606 
(cherry picked from commit dbbe4d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 18, 2022
Closed
miss-islington added a commit that referenced this pull request Mar 18, 2022
@miss-islington @serhiy-storchaka
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
d27af88 
(cherry picked from commit dbbe4d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Apr 25, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @serhiy-storchaka @hello-adam
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (pythonGH-31938)
36a5fbd 
(cherry picked from commit dbbe4d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni