-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-91265: Make old ctypes.macholib tests runned by python -m test
#32094
Conversation
python -m test
python -m test
python -m test
After rebuild against this PR: tests: Or |
python -m test
python -m test
Ping. This PR doesn't add extra logic, it just collects stuff into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally had some time to seriously look at this. The PR looks good to me, as the description says this moves some tests to explicit test files to ensure they are picked up by the regular test runs.
@arhadthedev : Sorry about the delay in reviewing, I had to find some time to seriously look at this and be sure that tests are correctly moved. Did you sign the CLA? The CLA check is blocking the merge of your PR. |
No worries! The issue needed the chance to collect feedback anyway.
Yes, both on the bpo (https://bugs.python.org/user40922) and after the migration (#91453 (comment), I'm one of authors there). So it's just a matter of waiting for the bot to be sorted out. P. S.: @ronaldoussoren (because I know that the "Mentioned" queue is an order of magnitude less that the "Participating" one). |
@ronaldoussoren I've reopened the PR to retrigger the bot; it worked. |
Some tests for
ctypes.macholib.dyld
and all tests forctypes.macholib.dylib
andctypes.macholib.framework
are located outside of expectedctypes.test
module and were not ported fromassert
tounittest
facilities. This causes the following problems:python -m test
so they are effectively deadpython -m ctypes.macholib.dyld
,python -m ctypes.macholib.dylib
, andpython -m ctypes.macholib.framework
This PR moves these tests into
ctypes.test.test_macholib
suit and wraps them asunittest.TestCase
.I believe this PR should be backported to not export unintended features in unintended places.
Fixes GH-91265.