Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32787: Better error handling in ctypes. #3727

Merged
merged 11 commits into from
Dec 5, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 24, 2017


len = PySequence_Length(fields);
len = PySequence_Size(fields);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why LengthSize?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PySequence_Size is more commonly used. PySequence_Length is just an outdated alias of PySequence_Size.

@serhiy-storchaka serhiy-storchaka changed the title bpo-31572: Get rid of PyObject_HasAttrString() in ctypes. bpo-32787: Better error handling in ctypes. Feb 7, 2018
@serhiy-storchaka serhiy-storchaka merged commit 398bd27 into python:master Dec 5, 2018
@bedevere-bot
Copy link

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants