Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak .codedoc.yml to make it more useful #71

Merged
merged 8 commits into from
Feb 14, 2017

Conversation

berkerpeksag
Copy link
Member

No description provided.

.codecov.yml Outdated
default:
threshold: 0.01
only_pulls: true
paths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/* changes, but shouldn't it also run on directories like Objects/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this means it only ends up being run for those directories, right?

Correct.

[...] but shouldn't it also run on directories like Objects/?

Good point. I'm reading docs again so I hopefully will have an answer :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.codecov.io/docs/commit-status#section-patch-status, we don't need to add specific directories. It should only look for the changes in PR.

We can also add directories to ignore: https://docs.codecov.io/docs/ignoring-paths

Copy link
Member

@briancurtin briancurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok from what I understand of the docs (particularly the coverage/status/{changes|project} part), but I'd prefer to leave it to another set of eyes to approve.

- "Mac/**/*"
- "PC/**/*"
- "PCbuild/**/*"
- "Tools/**/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add the Grammar directory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done.

@brettcannon
Copy link
Member

LGTM. If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great.

@berkerpeksag
Copy link
Member Author

Thanks for the review!

If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great.

$ curl -XPOST --data-binary @.codecov.yml https://codecov.io/validate
Valid!

# Pretty-printed version of the configuration below

@brettcannon
Copy link
Member

Then I say merge it and let python-dev (or -committers; wherever @Haypo emailed) know about the requisite change.

@berkerpeksag berkerpeksag merged commit 22ba52b into python:master Feb 14, 2017
@berkerpeksag berkerpeksag deleted the tweak-codecov branch February 14, 2017 09:56
jaraco pushed a commit that referenced this pull request Dec 2, 2022
lysnikolaou pushed a commit to lysnikolaou/cpython that referenced this pull request Apr 29, 2024
Test pasting with/without paste mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants