-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak .codedoc.yml to make it more useful #71
Conversation
.codecov.yml
Outdated
default: | ||
threshold: 0.01 | ||
only_pulls: true | ||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/*
changes, but shouldn't it also run on directories like Objects/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this means it only ends up being run for those directories, right?
Correct.
[...] but shouldn't it also run on directories like Objects/?
Good point. I'm reading docs again so I hopefully will have an answer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://docs.codecov.io/docs/commit-status#section-patch-status, we don't need to add specific directories. It should only look for the changes in PR.
We can also add directories to ignore
: https://docs.codecov.io/docs/ignoring-paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems ok from what I understand of the docs (particularly the coverage/status/{changes|project} part), but I'd prefer to leave it to another set of eyes to approve.
- "Mac/**/*" | ||
- "PC/**/*" | ||
- "PCbuild/**/*" | ||
- "Tools/**/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should add the Grammar directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, done.
LGTM. If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great. |
Thanks for the review!
$ curl -XPOST --data-binary @.codecov.yml https://codecov.io/validate
Valid!
# Pretty-printed version of the configuration below |
Then I say merge it and let python-dev (or -committers; wherever @Haypo emailed) know about the requisite change. |
Test pasting with/without paste mode
No description provided.