Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31014: Fix the webbrowser module. #7267

Merged
merged 2 commits into from
Jul 8, 2018
Merged

bpo-31014: Fix the webbrowser module. #7267

merged 2 commits into from
Jul 8, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 31, 2018 •
edited by bedevere-bot
Loading

webbrowser._synthesize() called webbrowser.register() with outdated signature.

Based on patch by John Still (#2689).

https://bugs.python.org/issue31014

@serhiy-storchaka
bpo-31014: Fix the webbrowser module.
69b2326 
webbrowser._synthesize() called webbrowser.register() with
outdated signature.  Based on patch by John Still.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels May 31, 2018
vstinner
vstinner approved these changes May 31, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested manually that test_webbrowser fails without the webbrowser.py fix.

You should credit John using the following tag at the end of your commit message (I didn't check if you already did it):

Co-Authored-By: John Still john@jmsdvl.com

GitHub recognizes this tag and will account John contribution!

@serhiy-storchaka serhiy-storchaka merged commit 25b804a into python:master Jul 8, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the webbrowser-syntesize branch July 8, 2018 07:22
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 8, 2018
@serhiy-storchaka @miss-islington
bpo-31014: Fix the webbrowser module. (pythonGH-7267)
a8f4983 
webbrowser._synthesize() called webbrowser.register() with
outdated signature.

Co-Authored-By: John Still <john@jmsdvl.com>
(cherry picked from commit 25b804a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-8183 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 25b804a9c21c735ce322877f105ebab2539ccfc1 2.7

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 25b804a9c21c735ce322877f105ebab2539ccfc1 3.6

miss-islington added a commit that referenced this pull request Jul 8, 2018
@miss-islington @serhiy-storchaka
bpo-31014: Fix the webbrowser module. (GH-7267)
a410f9f 
webbrowser._synthesize() called webbrowser.register() with
outdated signature.

Co-Authored-By: John Still <john@jmsdvl.com>
(cherry picked from commit 25b804a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 8, 2018
Closed
@michael-lazar michael-lazar mentioned this pull request Aug 12, 2018
Closed
@zmwangx zmwangx mentioned this pull request Aug 14, 2018
Closed
@jarun jarun mentioned this pull request Aug 14, 2018
Closed
@faho faho mentioned this pull request Aug 30, 2018
Closed
@ollpu ollpu mentioned this pull request Nov 14, 2018
Open
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni