bpo-17909: Document that json.load can accept a binary IO #7366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc/library/json.rst
Outdated
| @@ -262,6 +262,11 @@ Basic Usage | |||
| .. versionchanged:: 3.6 | |||
| All optional parameters are now :ref:`keyword-only <keyword-only_parameter>`. | |||
|
|
|||
| .. versionchanged:: 3.6 | |||
| *fp* can now be a :term:`file-like object` whose ``.read()`` method | |||
There was a problem hiding this comment.
Why not use just :term:`binary file`?
There was a problem hiding this comment.
I can go with that, was mostly matching the verbiage above (load after all only cares that the object has a .read() method)
serhiy-storchaka
added
needs backport to 3.6
docs
asottile
force-pushed
the
document_json_binary_io
branch
from
ac1c262 to
dd11bbf
Compare
vstinner
reviewed
Jun 4, 2018
| @@ -262,6 +262,10 @@ Basic Usage | |||
| .. versionchanged:: 3.6 | |||
| All optional parameters are now :ref:`keyword-only <keyword-only_parameter>`. | |||
|
|
|||
| .. versionchanged:: 3.6 | |||
| *fp* can now be a :term:`binary file`. The input encoding should be | |||
| UTF-8, UTF-16 or UTF-32. | |||
There was a problem hiding this comment.
IMHO the feature should also be documented in the body of the function documentation, not also in this versionchanged note.
asottile
force-pushed
the
document_json_binary_io
branch
from
dd11bbf to
e976fea
Compare
|
@vstinner @serhiy-storchaka look good now? |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2018
) (cherry picked from commit bb6366b) Co-authored-by: Anthony Sottile <asottile@umich.edu>
|
GH-7474 is a backport of this pull request to the 3.7 branch. |
|
GH-7475 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2018
) (cherry picked from commit bb6366b) Co-authored-by: Anthony Sottile <asottile@umich.edu>
miss-islington
added a commit
that referenced
this pull request
Jun 7, 2018
miss-islington
added a commit
that referenced
this pull request
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue17909