Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28240: timeit: Update repeat() doc #7419

Merged
merged 3 commits into from
Jun 6, 2018
Merged

bpo-28240: timeit: Update repeat() doc #7419

merged 3 commits into from
Jun 6, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 5, 2018 •
edited by bedevere-bot
Loading

Document that the default value of repeat changed from 3 to 5 in
Python 3.7.

https://bugs.python.org/issue28240

@vstinner
bpo-28240: timeit: Update repeat() doc
67ca3c1 
Document that the default value of repeat changed from 3 to 5 in
Python 3.7.
@vstinner vstinner requested a review from serhiy-storchaka June 5, 2018 10:43
@vstinner
Copy link
Member Author

vstinner commented Jun 5, 2018

@serhiy-storchaka: Is it what you expected in your https://bugs.python.org/issue33771 request? (Would you mind to review this PR please?)

serhiy-storchaka
serhiy-storchaka requested changes Jun 5, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update also the CLI docs and docstrings.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

@vstinner
Copy link
Member Author

vstinner commented Jun 6, 2018

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Jun 6, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the CLI documentation please.

@vstinner
Copy link
Member Author

vstinner commented Jun 6, 2018

And the CLI documentation please.

I updated timeit --help, but I missed that the CLI was also documented in Doc/library/timeit.rst. All documentation should now be up to date!

@vstinner vstinner merged commit 3ef769f into python:master Jun 6, 2018
@vstinner vstinner deleted the timeit_repeat branch June 6, 2018 15:55
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2018
@vstinner @miss-islington
bpo-28240: timeit: Update repeat() doc (pythonGH-7419)
14c9103 
Document that the default value of repeat changed from 3 to 5 in
Python 3.7.
(cherry picked from commit 3ef769f)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

GH-7457 is a backport of this pull request to the 3.7 branch.

vstinner added a commit that referenced this pull request Jun 6, 2018
@miss-islington @vstinner
bpo-28240: timeit: Update repeat() doc (GH-7419) (GH-7457)
cebd4b0 
Document that the default value of repeat changed from 3 to 5 in
Python 3.7.
(cherry picked from commit 3ef769f)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @bedevere-bot @miss-islington @serhiy-storchaka @the-knights-who-say-ni