bpo-33781: audioop: enhance rounding double as int #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the floor() call into fbound() to call floor() on a double rather than an int. The change might enhance the rounding.
|
VSTS: Windows-PR failed with an internal error: https://bugs.python.org/issue33782 |
serhiy-storchaka
added
type-bug
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-7450 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 6, 2018
Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding. Document also (int)double rounding mode. (cherry picked from commit 45e4efb) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
GH-7451 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 6, 2018
Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding. Document also (int)double rounding mode. (cherry picked from commit 45e4efb) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
Sorry, @vstinner, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Jun 6, 2018
Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding. Document also (int)double rounding mode. (cherry picked from commit 45e4efb) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
GH-7452 is a backport of this pull request to the 2.7 branch. |
vstinner
added a commit
that referenced
this pull request
Jun 6, 2018
vstinner
added a commit
that referenced
this pull request
Jun 6, 2018
Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding. Document also (int)double rounding mode. (cherry picked from commit 45e4efb) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the floor() call into fbound() to call floor() on a double
rather than an int. The change might enhance the rounding.
https://bugs.python.org/issue33781