Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33789: test_asyncio: Fix ResourceWarning #7460

Merged
merged 1 commit into from
Jun 6, 2018
Merged

bpo-33789: test_asyncio: Fix ResourceWarning #7460

merged 1 commit into from
Jun 6, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 6, 2018 •
edited by bedevere-bot
Loading

  • Close sockets and streams to fix ResourceWarning warnings
  • Catch also OSError to hide a traceback on an expected handshake
    error

https://bugs.python.org/issue33789

@vstinner
bpo-33789: test_asyncio: Fix ResourceWarning
360b9c9 
* Close sockets and streams to fix ResourceWarning warnings
* Catch also OSError to hide a traceback on an expected handshake
  error
@vstinner vstinner requested a review from 1st1 June 6, 2018 22:58
@vstinner vstinner requested a review from asvetlov as a code owner June 6, 2018 22:58
@vstinner vstinner merged commit 0eba7c3 into python:master Jun 6, 2018
@vstinner vstinner deleted the asyncio_close branch June 6, 2018 23:12
@vstinner
Copy link
Member Author

vstinner commented Jun 6, 2018

I will backport this change with other test_asyncio changes at once into 3.7.

@vstinner vstinner mentioned this pull request Jun 7, 2018
Merged
vstinner added a commit that referenced this pull request Jun 7, 2018
@vstinner
[3.7] bpo-33789: Backport test_asyncio fixes from master (GH-7478)
3c41761 
* bpo-33789: test_asyncio: Fix ResourceWarning (GH-7460)

* Close sockets and streams to fix ResourceWarning warnings
* Catch also OSError to hide a traceback on an expected handshake
  error

(cherry picked from commit 0eba7c3)

* bpo-33789, test_asyncio: Hide PendingDeprecationWarning (GH-7461)

Hide PendingDeprecationWarning in test__register_task_3().

(cherry picked from commit 7ed61e9)

* bpo-32676, test_asyncio: Fix warning in test_error_in_call_soon() (GH-7462)

Fix "<CoroWrapper ...> was never yielded from" warning in
PyTask_PyFuture_Tests.test_error_in_call_soon() of
test_asyncio.test_tasks.

Close manually the coroutine on error.

(cherry picked from commit 9f04f0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @1st1 @the-knights-who-say-ni @bedevere-bot