Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in Objects/odictobject.c documentation #8040

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

robertzk
Copy link
Contributor

@robertzk robertzk commented Jul 1, 2018

This fixes two tpyos in comments in the file implementing OrderedDict.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@robertzk
Copy link
Contributor Author

robertzk commented Jul 1, 2018

See CLA:

Contributor Agreement - signed.pdf

@robertzk
Copy link
Contributor Author

robertzk commented Jul 3, 2018

@taleinat Thank you! Is this good to merge? 😇

@taleinat
Copy link
Contributor

taleinat commented Jul 4, 2018

@robertzk, we're only waiting for approval of your signed contributor agreement.

@robertzk
Copy link
Contributor Author

robertzk commented Jul 5, 2018

@taleinat thank you! I just received this email:

Hi Robert,

All of the CLA bits are taken care of now. A committer needed to remove the CLA not signed label so that the verification bot could add the CLA signed label. So you're all set now except for final review of the changes.

Cheers,

Betsy

@taleinat taleinat merged commit 6f19fc6 into python:master Jul 6, 2018
@miss-islington
Copy link
Contributor

Thanks @robertzk for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8137 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2018
(cherry picked from commit 6f19fc6)

Co-authored-by: Robert Krzyzanowski <technoguyrob@gmail.com>
@bedevere-bot
Copy link

GH-8138 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2018
(cherry picked from commit 6f19fc6)

Co-authored-by: Robert Krzyzanowski <technoguyrob@gmail.com>
miss-islington added a commit that referenced this pull request Jul 6, 2018
(cherry picked from commit 6f19fc6)

Co-authored-by: Robert Krzyzanowski <technoguyrob@gmail.com>
miss-islington added a commit that referenced this pull request Jul 6, 2018
(cherry picked from commit 6f19fc6)

Co-authored-by: Robert Krzyzanowski <technoguyrob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants