Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in TypeVar docstring #8142

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Fix typo in TypeVar docstring #8142

merged 1 commit into from
Jul 7, 2018

Conversation

jdferreira
Copy link
Contributor

Fix a typo in the docstring of typing.TypeVar

"can be used do declare" → "can be used to declare"

@jdferreira
Fix typo in TypeVar docstring
55ae3ff 
"can be used do declare" → "can be used to declare"
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@ilevkivskyi ilevkivskyi merged commit 86bfed3 into python:master Jul 7, 2018
@bedevere-bot
Copy link

@ilevkivskyi: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @jdferreira for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8157 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2018
@jdferreira @miss-islington
Fix typo in TypeVar docstring (pythonGH-8142)
e6877d4 
"can be used do declare" → "can be used to declare"
(cherry picked from commit 86bfed3)

Co-authored-by: João D. Ferreira <jotomicron@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @jdferreira and @ilevkivskyi, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 86bfed372b81b8111a56a3311d537566d5df7f61 3.6

miss-islington added a commit that referenced this pull request Jul 7, 2018
@miss-islington @jdferreira
Fix typo in TypeVar docstring (GH-8142)
e019f98 
"can be used do declare" → "can be used to declare"
(cherry picked from commit 86bfed3)

Co-authored-by: João D. Ferreira <jotomicron@gmail.com>
@Mariatta
Copy link
Member

Is backport to 3.6 still needed?

@gvanrossum
Copy link
Member

It's minor enough that I wouldn't bother with a backport.

@ilevkivskyi
Copy link
Member

It's minor enough that I wouldn't bother with a backport.

I agree.

@ilevkivskyi ilevkivskyi removed their assignment Aug 1, 2018
@Mariatta
Copy link
Member

Mariatta commented Aug 1, 2018

In that case I'll remove the needs backport label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jdferreira @the-knights-who-say-ni @bedevere-bot @miss-islington @Mariatta @gvanrossum @ilevkivskyi