Add missing closing parentheses #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Jul 7, 2018
serhiy-storchaka
added
needs backport to 3.6
docs
|
Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-8163 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 7, 2018
(cherry picked from commit 03dd0e7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
|
Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 7, 2018
(cherry picked from commit 03dd0e7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
|
GH-8166 is a backport of this pull request to the 3.6 branch. |
|
@serhiy-storchaka I believe this doesn't apply to 2.7. The comment were the fix was made does not exist there. |
miss-islington
added a commit
that referenced
this pull request
Jul 7, 2018
(cherry picked from commit 03dd0e7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jul 7, 2018
(cherry picked from commit 03dd0e7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.