Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91768: C API no longer use "const PyObject*" type #91769

Merged
merged 2 commits into from
Apr 21, 2022
Merged

gh-91768: C API no longer use "const PyObject*" type #91769

merged 2 commits into from
Apr 21, 2022

Conversation

vstinner
Copy link
Member

Py_REFCNT(), Py_TYPE(), Py_SIZE() and Py_IS_TYPE() functions argument
type is now "PyObject*", rather than "const PyObject*".

  • Replace also "const PyObject*" with "PyObject*" in functions:

    • _Py_strhex_impl()
    • _Py_strhex_with_sep()
    • _Py_strhex_bytes_with_sep()
  • Remove _PyObject_CAST_CONST() and _PyVarObject_CAST_CONST() macros

  • Py_IS_TYPE() can now use Py_TYPE() in its implementation

Py_REFCNT(), Py_TYPE(), Py_SIZE() and Py_IS_TYPE() functions argument
type is now "PyObject*", rather than "const PyObject*".

* Replace also "const PyObject*" with "PyObject*" in functions:

  * _Py_strhex_impl()
  * _Py_strhex_with_sep()
  * _Py_strhex_bytes_with_sep()

* Remove _PyObject_CAST_CONST() and _PyVarObject_CAST_CONST() macros
* Py_IS_TYPE() can now use Py_TYPE() in its implementation
@vstinner
Copy link
Member Author

This change is backward compatible since modified macros cast their argument to PyObject*.

@vstinner
Copy link
Member Author

cc @erlend-aasland

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the documentation.

@vstinner
Copy link
Member Author

You also need to update the documentation.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants