gh-89653: PEP 670: Convert PyBytes macros to functions #91990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include/cpython/bytearrayobject.h
Outdated
Comment on lines
17
to
19
| #define _PyByteArray_CAST(op) \ | ||
| (assert(PyByteArray_Check(op)), \ | ||
| _Py_reinterpret_cast(PyByteArrayObject*, op)) |
There was a problem hiding this comment.
Why not write this out in the static inline functions? Ditto for _PyBytes_CAST.
There was a problem hiding this comment.
The purpose of this macro is to cast to PyByteArrayObject*. If it's converted to a function, what would be the argument type? How do you prevent introducing new compiler warnings?
Convert the following macros to static inline functions: * PyByteArray_AS_STRING() * PyByteArray_GET_SIZE() * PyBytes_AS_STRING() * PyBytes_GET_SIZE() Limited C API version 3.11 no longer casts arguments. Add _PyBytes_CAST() and _PyByteArray_CAST() macros.
|
I rebased my PR to get the renamed |
erlend-aasland
approved these changes
May 3, 2022
|
Thanks for the review @erlend-aasland. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the following macros to static inline functions:
Limited C API version 3.11 no longer casts arguments.
Add _PyBytes_CAST() and _PyByteArray_CAST() macros.