gh-99032: datetime docs: Encoding is no longer relevant #93365
Conversation
The `.strftime()` methods return a Unicode string as of Python 3.0.
AA-Turner
added
skip issue
needs backport to 3.10
|
Could you create a ticket to describe the issue and make it easier to track the fixes? Thanks |
|
@merwok @nanjekyejoannah I could open an issue, sure, I'm just not sure what to say beyond what I've written here. Maybe,
Actually, now that I think about it again, maybe it'd be better to change the warning from "may contain Unicode characters encoded ..." to "may contain non-ASCII characters." Say the word and I'll open an issue so we can discuss that. |
|
That’s just the process we follow to keep things manageable 🙂 Full details here: https://devguide.python.org/triage/issue-tracker/ |
|
Thanks for the PR. I think you will need to include the issue number in your PR title :) |
AlexWaygood
changed the title
AlexWaygood
changed the title
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…GH-93365) This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string. --------- (cherry picked from commit 2aa22f7) Co-authored-by: William Andrea <william.j.andrea@gmail.com> Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>
|
GH-103788 is a backport of this pull request to the 3.11 branch. |
* main: (53 commits) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) Add tests for empty range equality (python#103751) pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713) ...
* superopt: (82 commits) pythongh-101517: fix line number propagation in code generated for except* (python#103550) pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) ...
) (#103788) This removes a section of the `strftime` and `strptime` documentation that refers to a bygone era when `strftime` would return an encoded byte string. --------- (cherry picked from commit 2aa22f7) Co-authored-by: William Andrea <william.j.andrea@gmail.com> Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
The
.strftime()methods return a Unicode string as of Python 3.0.For reference, under the hood, the
.strftime()methods usetime.strftime(), whose return value is defined here for the current tip of the main branch and here for 3.0.Please check my work before merging to make sure I've understood what the docs are saying. I'm also not super familiar with C or RST, but I'm quite sure I've understood them correctly.
Backports should be made to all current versions.
BTW, encoding isn't mentioned in the
timedocs, so no changes required there I don't think.